prometheus-community / helm-charts

Prometheus community Helm charts
Apache License 2.0
5.12k stars 5.02k forks source link

[prometheus-json-exporter] Fix scrapeTimeout validation #4916

Open CoolDuke opened 1 month ago

CoolDuke commented 1 month ago

What this PR does / why we need it

The current implementation checks for the non-existent value serviceMonitor.scrapeTimeout which leads to a fallback to the default scrape timeout configured in Prometheus (usually 10s).

The PR ensures that the configured scrapeTimeout value for a target is used or if not defined the default value is used.

Which issue this PR fixes

none

Special notes for your reviewer

Checklist