search

prometheus-community / ipmi_exporter

Remote IPMI exporter for Prometheus
MIT License
459 stars 131 forks source link

Update build #171

Closed SuperQ closed 11 months ago

SuperQ commented 11 months ago
jplanckeel commented 11 months ago

Hi, this is the first time I've contributed here but I don't think it's cool to close the MR without any info and open one in // for this.

We could have made this one evolve to reach the desired standard.

https://github.com/prometheus-community/ipmi_exporter/pull/169

Thanks in any case for the update.

jplanckeel commented 11 months ago

Hello, it's possible to create a release ?

SuperQ commented 11 months ago

@jplanckeel Sure, would you like to help with this? You would need to edit the CHANGELOG.md and VERSION files.

We generally only list the user visible changes, not mechanical updates like Go versions or other maintenance PRs.

jplanckeel commented 11 months ago

Hi @SuperQ, there have been quite a few version upgrades of GO and deps, this could be a good thing. In addition, it would provide users with a tag other than latest or master for their production.

I'll prepare the MR for you. You're more in favor of a fix or minor bump ?

I see new feature, i propose a version 1.7.0

jplanckeel commented 11 months ago

The PR : https://github.com/prometheus-community/ipmi_exporter/pull/173

Thank you 👍