prometheus-community / ipmi_exporter

Remote IPMI exporter for Prometheus
MIT License
459 stars 131 forks source link

System Firmware Revision throws exception #194

Closed huseyinbabal closed 3 months ago

huseyinbabal commented 4 months ago

System Firmware Revision info is somehow is not available on all firmwares, and it throws an exception that also prevents entire metric collection. It could be fallback to Firmware Revision if System Firmware Version is missing from bmc-info command output. You can see the outputs from Dell and Super Micro Machines for missing System Firmware Version

Dell (Has SFR)

Manufacturer ID       : Dell Inc. (674)
Product ID            : <redacted>
Auxiliary Firmware Revision Information : <redacted>

Device GUID : <redacted>

System GUID : <redacted>

System Firmware Version       : 2.17.1
System Name                   :
Primary Operating System Name :
Operating System Name         :
Present OS Version Number     :
BMC URL                       : https://172.....

Super Micro (Does not have SFR)

Manufacturer ID       : Super Micro Computer Inc. (...)
Product ID            : <redacted>
Auxiliary Firmware Revision Information : <redacted>

Device GUID : <redacted>

System GUID : <redacted>

Channel Information

Channel Number       : 0
Medium Type          : IPMB (I2C)
Protocol Type        : IPMB-1.0
Active Session Count : 0
Session Support      : session-less
Vendor ID            : Intelligent Platform Management Interface forum (...)
bitfehler commented 3 months ago

Thanks for bringing this up, but I am a bit confused. The System Firmware Version is already optional exactly for this reason, it just logs a message if absent. Are you sure that this is what brings down the exporter? Or is it maybe some other attribute that is missing? Maybe the Firmware Revision is what's missing? I can't tell from the data you provide, it seems to be cropped at the top...

If in doubt, can you maybe post the exporter log of a scrape attempt?

huseyinbabal commented 3 months ago

Hi @bitfehler somehow I was using the outdated version of the collector, I don't even have bmc_collector. I will try this again, and will inform you here about the status.

huseyinbabal commented 3 months ago

Recent version just fixed the issue, thanks.