search

prometheus-community / jiralert

JIRA integration for Prometheus Alertmanager
Apache License 2.0
336 stars 129 forks source link

Proposal: Move to Alertmanager. #145

Open bwplotka opened 1 year ago

bwplotka commented 1 year ago

Given the popularity and use, I would like to propose pushing this code to Alertmanager notify package.

I got information AM maintainers will consider this (:

We need, however, maintainer for this notifier. Any volunteers? (:

bwplotka commented 1 year ago

We also need official maintainer. I can co-maintain, but we need someone else to own this, so looking for volunteers (:

twotired commented 1 year ago

@bwplotka What's involved with being the maintainer? I'm open to being co-maintainer at least.

bwplotka commented 1 year ago

Just a general review of related PRs, issues and security fixes (:

Thanks, noted! Are you on the cncf slack?

twotired commented 1 year ago

I am there, in the #jiralert channel

raonisiann commented 1 year ago

I can help as maintainer as well if you still needed. I joined on slack channel #jiraalert

holger-waschke commented 1 year ago

I can help as maintainer aswell if help is needed. We use jiralert in a large environment.

bwplotka commented 1 year ago

Amazing thanks! I think we have nice collection of contributors to attempt the move. Any of you would have time to prepare a PR to Alertmanager? I can even create feature branch for us. We can then together work towards PR with jiralert plugin in https://github.com/prometheus/alertmanager as well as documentation (: I will be there to consult and review (together with Alertmanager maintainers e.g. @simonpasquier)

twotired commented 1 year ago

I was a little confused by what's needed here. I thought there was a need for additional maintainers of this project so that there could be a greater capacity to review and approve PRs and create new releases. Is that not in consideration?

I would be open to helping with the migration, but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

bwplotka commented 1 year ago

Sorry for confusion, but as description suggests (https://github.com/prometheus-community/jiralert/issues/145#issue-1508084656) this issue is about proposing it to Alertmanager and maintaining similar code (with the same functionality) there (:

but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

Yup, feel free to propose changes to this repo for now. Whatever we do here will be useful in Alertmanager 👍🏽

jkroepke commented 1 year ago

I've setup an PR on alertmanager

jkroepke commented 3 months ago

The PR is merged on AM site.