prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
508 stars 188 forks source link

Add script for ZFS snapshots #136

Closed lstrojny closed 1 year ago

lstrojny commented 1 year ago

Generates two metrics for ZFS snapshots:

dswarbrick commented 1 year ago

Please use the official Prometheus client_python library, rather than a homegrown metric printing function.

lstrojny commented 1 year ago

@dswarbrick done

dswarbrick commented 1 year ago

@lstrojny Can you also include some sample command outputs (in the mock/fixtures directory) and optionally a mock zfs script (see existing examples in mock directory, so that we can (eventually) write tests for this collector?

dswarbrick commented 1 year ago

Great stuff, thanks for your contribution.

PS: Any interest in merging the functionality of zfs_zpool.sh into this collector? :wink:

lstrojny commented 1 year ago

Thanks! I probably won’t find the time to move zfs_zpool.sh into this collector, although a general purpose zfs.py would be nice