Closed lstrojny closed 1 year ago
Please use the official Prometheus client_python library, rather than a homegrown metric printing function.
@dswarbrick done
@lstrojny Can you also include some sample command outputs (in the mock/fixtures
directory) and optionally a mock zfs
script (see existing examples in mock
directory, so that we can (eventually) write tests for this collector?
Great stuff, thanks for your contribution.
PS: Any interest in merging the functionality of zfs_zpool.sh into this collector? :wink:
Thanks! I probably won’t find the time to move zfs_zpool.sh into this collector, although a general purpose zfs.py would be nice
Generates two metrics for ZFS snapshots: