prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
505 stars 188 forks source link

Systemd unit and timer for smartmon #173

Open LukeLR opened 1 year ago

LukeLR commented 1 year ago

I added systemd unit and timers for smartmon.sh, so they can be easily installed for running the smartmon script periodically as a service. What do you think? :)

dswarbrick commented 1 year ago

Generally we leave such things to the distros which package the contents of this repo, since it usually involves distro-specific paths and users. For example, the Debian (and Ubuntu) package prometheus-node-exporter-collectors already includes systemd units and timers for five of the scripts in this repo.

LukeLR commented 1 year ago

Thanks for the reply. That's unfortunate, especially since no distro-specific paths are required if the scripts are simply installed in $PATH. I'd like to see sytemd units upstream, even if distros package systemd units, they can use them as an example. But if you don't want that in, I'll maintain a fork for myself.

dswarbrick commented 5 months ago

I think that if we're going to include such things in this repo, they belong in a "contrib" directory, rather than the root directory. You'll also need to sign the DCO if you wish these to be considered for merging.