search

prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
505 stars 188 forks source link

Allow setting different root dir for apt #178

Open egvimo opened 1 year ago

egvimo commented 1 year ago

See #171

Implemented as command line argument instead of env var.

Additionally I've refactored a little bit. Fixed linting issues and created a separate function to use in other scripts.

macetw commented 1 year ago

Definitely needed to manage within a docker container. Suggest moving this forward.

macetw commented 1 year ago

This PR is only managing it for the apt script. Do we need this setting for any of the other scripts in this code?

A quick glance found deleted_libraries.py would require this change. fstab_check.sh. Gosh all of them?

egvimo commented 1 year ago

I've created an exporter using the script from this PR which runs inside a Kubernetes cluster inside a container exporting the metrics via ServiceMonitor: https://github.com/egvimo/apt-exporter This works even with a read only mount of the host directory.

anarcat commented 1 year ago

should this be merged, or should we look at removing apt_info.py in favor of the apt-exporter?

dswarbrick commented 1 year ago

should this be merged, or should we look at removing apt_info.py in favor of the apt-exporter?

If we remove a script simply because a dedicated exporter exists, then we would also need to remove the smartmon.{py,sh} and ipmitool scripts.

anarcat commented 1 year ago

If we remove a script simply because a dedicated exporter exists, then we would also need to remove the smartmon.{py,sh} and ipmitool scripts.

that would solve #119 at least :p