Add Open Compute Project log page (when available) to stats gathered on NVMe devices.

prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector

Apache License 2.0

511 stars 191 forks source link

Add Open Compute Project log page (when available) to stats gathered on NVMe devices. #223

Open sbates130272 opened 1 week ago

sbates130272 commented 1 week ago

It would be desirable to have the nvme collector(s) gather information from the OCP stats log page as well as from the smart-log page. Note this has been discussed in the nvme-cli project. I am happy to work up a PR for this.

One question I have is if this needs to be done for the python and the shell script? Is the shell script being depreciated?

dswarbrick commented 1 week ago

Yes, the shell script will be deprecated.

dswarbrick commented 2 days ago

@sbates130272 You might want to hold off submitting any PR just yet, as it seems we will have to do some non-trivial refactoring of the collector. See #226.

sbates130272 commented 1 day ago

Thanks @dswarbrick. I will keep a track of #226 and see how things play out.