search

prometheus-community / prometheus-playground

Turnkey sandbox projects demonstrating a wide variety of Prometheus use cases
Apache License 2.0
166 stars 24 forks source link

[DNM] *: fix command parameter for latest Prometheus #4

Closed simonpasquier closed 5 years ago

simonpasquier commented 5 years ago

The next latest image (eg v2.6.0) will break if started with --config.file=/etc/prometheus/prometheus.yml because the option is already included in the entrypoint. This PR should only be merged after v2.6.0 is out.

See https://github.com/prometheus/prometheus/pull/4796

lucperkins commented 5 years ago

I’ll also investigate ways of tying the tutorials to specific versions. Since they’re meant to be “turnkey” the reliance on latest is just begging for bitrot.

lucperkins commented 5 years ago

@simonpasquier Feel free to merge on your own when the time comes, if you have the proper privileges. Otherwise ping me when 2.6.0 drops (I'm not super tapped into Prometheus releases so I might miss it).

RichiH commented 5 years ago

prometheus-team has full rights on the org, so he should be fine.

lucperkins commented 5 years ago

@simonpasquier FYI, see PR #5. That will enable us to explicitly set image tags across sub-projects in the future and thus avoid latest-related issues like the one you point out here.

lucperkins commented 5 years ago

It looks like the flag is included in 2.5.* as well, so this can be merged now.