prometheus-community / smartctl_exporter

Export smartctl statistics to prometheus
Apache License 2.0
293 stars 88 forks source link

Missing smartctl flags #190

Closed intelfx closed 9 months ago

intelfx commented 9 months ago

I see from the code that it supports collecting a lot more metrics than the included smartctl call will generate. For instance, this is supposed to collect the ATA devstat log:

https://github.com/prometheus-community/smartctl_exporter/blob/3463e4fcd5a3e0bd5b273a07c64231df3decb83d/smartctl.go#L445

However, smartctl --json --info --health --attributes will never print it. There's also support for other log pages which, again, are absent in the smartctl output as invoked.

Consider switching to smartctl --xall.

lahwaacz commented 9 months ago

This is a duplicate of https://github.com/prometheus-community/smartctl_exporter/issues/92

NiceGuyIT commented 9 months ago

@intelfx Join the conversation in #92.