prometheus-community / smartctl_exporter

Export smartctl statistics to prometheus
Apache License 2.0
265 stars 79 forks source link

Added determining device type and use it at scrape data #205

Closed zxzharmlesszxz closed 2 months ago

zxzharmlesszxz commented 4 months ago

Removed smartctl.device param - smartctl.device-include/smartctl.device-exclude fully covers this Added determining device type and use it at scrape data

Maybe fix issues: https://github.com/prometheus-community/smartctl_exporter/issues/89 https://github.com/prometheus-community/smartctl_exporter/issues/26 And no need pr https://github.com/prometheus-community/smartctl_exporter/pull/107

k0ste commented 1 month ago

Would that handle systems with more than one HBA?

Of course

That would be ideal of course, but “do the desired thing in all kinds of scenarios” often is by far the hardest to implement.

This is not difficult to implement, this is the 4th variant - when scan find the megaraid devices in list, - enable the logic specifically for these devices (if megaraid: ...). As I described above, we need to understand what the design should be so that we can immediately write code that will be merged

Ranler commented 1 month ago

Please support cciss(Compaq Smart Array Controller) device type, we can get deivces by smartctl -a -d cciss,1 /dev/sg1, but it will not be scan automatically.

tacerus commented 1 month ago

I think this patch should be reverted. It completely disengages the --smartctl.device option causing involuntary scanning of all devices.