search

prometheus-junkyard / mesos_exporter

Prometheus exporter for Mesos, deprecated.
Apache License 2.0
42 stars 22 forks source link

Docker image on Docker Hub #16

Closed a-nldisr closed 8 years ago

a-nldisr commented 8 years ago

Dockerfile in this repo is pretty empty, can you update the dockerfile with the contents of #1

juliusv commented 8 years ago

Could you explain what exactly you would like to see in the current Dockerfile that is missing? The current one in this repo uses sdurrheimer/alpine-golang-make-onbuild as its base, which creates really small container images, so that's better than the one mentioned in #1 AFAICS (https://hub.docker.com/r/antonlindstrom/mesos-exporter/~/dockerfile/). Also, the -config.file option does not exist in the Mesos Exporter at head, so that is gone as well.

a-nldisr commented 8 years ago

Currently the Dockerfile content is this:

FROM sdurrheimer/alpine-golang-make-onbuild MAINTAINER The Prometheus Authors prometheus-developers@googlegroups.com

EXPOSE 9105

I see no ADD of the code from mesos_exporter

antonlindstrom commented 8 years ago

@a-nldisr This does the adding of the code: https://github.com/sdurrheimer/alpine-golang-make-onbuild/blob/master/Dockerfile#L13

a-nldisr commented 8 years ago

Ok so in fact you only expose the port and call another image that has all the go code already inserted? Could it be an idea to configure the entrypoint for mesos_exporter in this dockerfile to take away confusion for an nitwit like me?