prometheus-junkyard / mesos_exporter

Prometheus exporter for Mesos, deprecated.
Apache License 2.0
42 stars 22 forks source link

Add all master metrics #21

Closed bobrik closed 8 years ago

bobrik commented 8 years ago

It feels dirty. Maybe we should generate this list from a few maps instead.

type mesosMetricMapping struct {
  metric string
  help   string
}

masterGauges := map[string]mesosMetricMapping{
 "mesos_master_cpus_revocable_total":  {"master/cpus_revocable_total", "Total number of revocable CPUs."},
 // ...
}

masterCounters := map[string]mesosMetricMapping{
  // ...
}

Metrics for messages look like they should be one metric with labels. Should I rewrite that?

Let me know what you think.

brian-brazil commented 8 years ago

Someone with a bit more mesos knowledge should also take a look, I'm a bit rusty. @discordianfish ?

brian-brazil commented 8 years ago

Metrics for messages look like they should be one metric with labels. Should I rewrite that?

That'd probably make sense.

bobrik commented 8 years ago

Just found http://mesos.apache.org/documentation/latest/monitoring/, it makes sense to copy descriptions from there.

bobrik commented 8 years ago

Updated, PTAL. It seems that messages are too differen to put them into the same key.

bobrik commented 8 years ago

Combined failure reasons and added number of tasks per framework. Can you take another look?

discordianfish commented 8 years ago

@bobrik: See #18 - You should probably base any changes upon https://github.com/mesosphere/mesos_exporter, we want to deprecate this repo. Does that work for you?

@brian-brazil / @juliusv I need permissions to the junkyard org to move this repo there.

bobrik commented 8 years ago

D'oh

discordianfish commented 8 years ago

I know, I know it sucks to waste time :( I'm sorry, I should have move this repo already. Will do as soon as I have the permissions. I hope the mesosphere exporter includes everything you need. Either way, it should be a much nicer base to work with.

brian-brazil commented 8 years ago

I guess this PR is obsolete then.