search

prometheus-junkyard / mesos_exporter

Prometheus exporter for Mesos, deprecated.
Apache License 2.0
42 stars 22 forks source link

Clean up some bits in the Mesos exporter #4

Closed juliusv closed 9 years ago

juliusv commented 9 years ago

@antonlindstrom With regards to the metric name changes, I changed them to be a bit closer to the ones that @discordianfish created for cAdvisor in https://github.com/google/cadvisor/blob/master/metrics/testdata/prometheus_metrics.

antonlindstrom commented 9 years ago

@juliusv Awesome, looks really good! Thanks!

juliusv commented 9 years ago

@antonlindstrom Actually, one more question: the metrics are per-task, but I don't see a "task" label in any of them. Is that meant to be the service label? Not exactly sure about the Mesos concepts here...

antonlindstrom commented 9 years ago

@juliusv Yeah, the task name is in the service label at the moment, I think that task would be more appropriate.

Thanks!

juliusv commented 9 years ago

@antonlindstrom Cool, changed service to task now!

juliusv commented 9 years ago

@brian-brazil also had some general comments about the structure - I think about it being better running one of these per Mesos slave instead of scraping all Mesos slaves from one exporter. Once there's some clarity/agreement on that, I might get to that at some point...

juliusv commented 9 years ago

Merging this one for now. We can always change more later :)

antonlindstrom commented 9 years ago

Awesome, thanks!