wal: Inject LiveReader metrics rather than registry

prometheus-junkyard / tsdb

The Prometheus time series database layer.

Apache License 2.0

835 stars 178 forks source link

wal: Inject LiveReader metrics rather than registry #649

Closed brancz closed 5 years ago

brancz commented 5 years ago

LiveReaders are instantiated number of remote write queues * segments times, which would cause double registration of the metrics. Instead this should be orchestrated by the layer above, instantiating the live reader.

Fixes #646

@bwplotka @cstyan @krasi-georgiev @csmarchbanks

bwplotka commented 5 years ago

Can you this item to CHANGELOG (Actually it should in 0.9.0 changelog partially)