prometheus-junkyard / tsdb

The Prometheus time series database layer.
Apache License 2.0
835 stars 178 forks source link

NumSeries() method for BlockReader interface #656

Closed codesome closed 5 years ago

codesome commented 5 years ago

This is a broken down piece of #627 and is required by #627.

krasi-georgiev commented 5 years ago

the ReadOnly PR exposes the meta for the block and would cover your case as well. https://github.com/prometheus/tsdb/pull/588

I was waiting for one final review, but if no one replies will merge in 1-2 days.

codesome commented 5 years ago

588 doesn't give NumSeries for head. So either a part of this PR would be needed or the Meta returned by Head needs to expose NumSeries.

krasi-georgiev commented 5 years ago

yes I meant to add the NumSeries the read only db PR.

codesome commented 5 years ago

Closing this as its available as .Meta().NumSeries after https://github.com/prometheus/tsdb/pull/588 was merged.