search

prometheus-operator / kube-prometheus

Use Prometheus to monitor Kubernetes and applications running on Kubernetes
https://prometheus-operator.dev/
Apache License 2.0
6.68k stars 1.92k forks source link

Bug in v0.7.0 - please tag with fix #946

Open a8j8i8t8 opened 3 years ago

a8j8i8t8 commented 3 years ago

What happened? There is a bug in release v0.7.0 Did you expect to see some different? Service names for controller-manager, scheduler and dns are same. How to reproduce it (as minimally and precisely as possible): Use v0.7.0 to create manifests for kube-prometheus/kube-prometheus-kops.libsonnet Environment

Anything else we need to know?: Following is the issue.

{
  prometheus+:: {
    kubeControllerManagerPrometheusDiscoveryService: service(
      'kube-controller-manager-prometheus-discovery',
      'kube-system',
      { 'k8s-app': 'kube-controller-manager' },
      { 'k8s-app': 'kube-controller-manager' },
      [{ name: 'https-metrics', port: 10257, targetPort: 10257 }]
    ),
    kubeSchedulerPrometheusDiscoveryService: service(
      'kube-controller-manager-prometheus-discovery',
      'kube-system',
      { 'k8s-app': 'kube-scheduler' },
      { 'k8s-app': 'kube-scheduler' },
      [{ name: 'https-metrics', port: 10259, targetPort: 10259 }]
    ),
    kubeDnsPrometheusDiscoveryService: service(
      'kube-controller-manager-prometheus-discovery',
      'kube-system',
      { 'k8s-app': 'kube-dns' },
      { 'k8s-app': 'kube-dns' },
      [{ name: 'metrics', port: 10055, targetPort: 10055 }, { name: 'http-metrics-dnsmasq', port: 10054, targetPort: 10054 }]
    ),
  },
}
paulfantom commented 3 years ago

I suggest using release-0.7 branch.

@prometheus-operator/kube-prometheus-reviewers why do we even tag and do releases when in docs we suggest using branches and not tags? This seems confusing and IMHO we should either stop tagging or use patch versions every time we update release-* branch. WDYT?