search

prometheus-operator / prometheus-operator

Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes
https://prometheus-operator.dev
Apache License 2.0
9.02k stars 3.7k forks source link

Replace `github.com/go-kit/klog` by the new `slog` package #6183

Open simonpasquier opened 9 months ago

simonpasquier commented 9 months ago

slog provides structured logging out of the box. It should be a good fit to replace github.com/go-kit/klog which is used currently.

Advantages:

Ayush9026 commented 6 months ago

/assign @Ayush9026

slashpai commented 6 months ago

@Ayush9026 I see a pr already created for this, follow up/ coordinate on the PR if you like to contribute as well

perebaj commented 3 months ago

Hey guys, I want to contribute to this PR, but looking at it, there is a draft PR addressing this issue. Do you think that is better to follow up on the current one started by @PaulBarrie or create a new one?

simonpasquier commented 3 months ago

@perebaj try to sync with @PaulBarrie on the PR maybe?

perebaj commented 3 months ago

@perebaj try to sync with @PaulBarrie on the PR maybe?

For sure, I will take a look into his job. But I think that he discontinued the PR because there hasn't been any commit in the last 4 months.

In the worst case, I can use it as a reference.

PaulBarrie commented 3 months ago

Hello, yes did not have time to finish. You can use it of course. One of the main problem I encountered was to inject the logger to third-party applications like thanos.

perebaj commented 3 months ago

Hello, yes did not have time to finish. You can use it of course. One of the main problem I encountered was to inject the logger to third-party applications like thanos.

Thanksss, then I will start where you stopped

ArthurSens commented 3 weeks ago

I've just noticed that the migration is still on-going. I'm opening this again.

The current problem is that we're still using third-party libraries that don't provide constructors with slog