prometheus / OpenMetrics

Evolving the Prometheus exposition format into a standard.
https://openmetrics.io
Apache License 2.0
2.37k stars 171 forks source link

Missing metrics descriptors in tests #228

Closed sinkingpoint closed 3 years ago

sinkingpoint commented 3 years ago

In the spec, it says:

A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata.

but then we have tests like

that are missing UNIT descriptors and

that are missing all metadata. Is this valid, or are the tests wrong? I'm inclined to err on the side that the tests are right and that this statement should be removed from the spec (or at least clarified)

brian-brazil commented 3 years ago

That line is in the data model section, how that is rendered is covered in the data formats section. Both the spec and tests are correct.