Stop importing deprecated github.com/golang/protobuf

prometheus / client_golang

Prometheus instrumentation library for Go applications

https://pkg.go.dev/github.com/prometheus/client_golang

Apache License 2.0

5.38k stars 1.18k forks source link

Stop importing deprecated github.com/golang/protobuf #1175

Open bwplotka opened 1 year ago

bwplotka commented 1 year ago

AC:

Move to https://pkg.go.dev/google.golang.org/protobuf API

See https://github.com/prometheus/common/issues/317

bwplotka commented 1 year ago

Fixed by https://github.com/prometheus/client_golang/pull/1183

zhsj commented 1 year ago

@bwplotka since github.com/golang/protobuf is still in go.mod, thus I didn't close it by commit message. Probably keep it open until the tests have migrated as well?

SuperQ commented 1 year ago

I agree, we still need to clean up the tests so the Go modules dependencies are fixed.

drobazko commented 1 year ago

Hey folks. Any updates on this issue?

rufreakde commented 1 year ago

@SuperQ any updates?

SuperQ commented 1 year ago

It's up to the client_golang maintainers to cut a new release.

ash2k commented 1 year ago

I found https://github.com/prometheus/common/pull/509 that should help remove the deprecated proto package from the transitive dependency list.

ash2k commented 1 year ago

Another chain of dependencies is via the github.com/prometheus/common too:

go mod why -m github.com/golang/protobuf
# github.com/golang/protobuf
github.com/prometheus/common/config
golang.org/x/oauth2
golang.org/x/oauth2/internal
google.golang.org/appengine/urlfetch
github.com/golang/protobuf/proto

Work to address that is tracked in https://github.com/golang/appengine/issues/228. After it's done, someone will need to update golang.org/x/oauth2 to use the new version (there is a google.golang.org/appengine/v2 already, so a major version bump will be needed).