prometheus / client_golang

Prometheus instrumentation library for Go applications
https://pkg.go.dev/github.com/prometheus/client_golang
Apache License 2.0
5.34k stars 1.17k forks source link

replace github.com/golang/protobuf with google protobuf #1277

Open ahrycej opened 1 year ago

ahrycej commented 1 year ago

Replace the github.com/golang/protobuf-1.5.3 with google code

The whole project seem to be depricated and it is recommended to go for google from https://github.com/golang/protobuf

"It has been superseded by the google.golang.org/protobuf module, which contains an updated and simplified API, support for protobuf reflection, and many other improvements. We recommend that new code use the google.golang.org/protobuf module.

Versions v1.4 and later of github.com/golang/protobuf are implemented in terms of google.golang.org/protobuf. Programs which use both modules must use at least version v1.4 of this one."

edoger commented 1 year ago

To solve this problem, you need to start from github.com/prometheus/common, the ultimate reason is that github.com/prometheus/common depends on github.com/matttproud/golang_protobuf_extensions (very old and out of date).

rufreakde commented 1 year ago

Linking issue: https://github.com/prometheus/common/issues/317

pavelpatrin commented 11 months ago

+1