search

prometheus / client_model

Data model artifacts for Prometheus.
http://prometheus.io
Apache License 2.0
74 stars 74 forks source link

Add unit field to MetricFamily proto message #75

Closed vesari closed 10 months ago

vesari commented 10 months ago

Add unit field to MetricFamily proto message. This is a dependency of https://github.com/prometheus/client_golang/pull/1392.

vesari commented 10 months ago

LGTM. Thank you very much.

Please remember that the same change is needed in https://github.com/prometheus/prometheus/blob/main/prompb/io/prometheus/client/metrics.proto . (It's not ideal that we maintain a proto2 and a proto3 implementation in parallel, and that in two different repositories. We have to fix that eventually, but for now, we have to jump through this hoop.)

Thanks a lot for pointing that out. I'll make the necessary changes there too.