prometheus / client_ruby

Prometheus instrumentation library for Ruby applications
Apache License 2.0
505 stars 150 forks source link

UTF-8: Implement support in Ruby client library #306

Open ywwg opened 4 months ago

ywwg commented 4 months ago

As in https://github.com/prometheus/client_golang/issues/1369 and https://github.com/prometheus/client_java/issues/916, the Ruby client library needs to be updated to support UTF-8.

Tasks:

For background and references see https://github.com/prometheus/prometheus/issues/13095

Sinjo commented 4 months ago

Hey, thanks for the heads up. I've got a rough idea in my head of how those changes will fit into the codebase.

I've given the proposal a read and one thing that stuck out to me is that grouping key labels in the pushgateway client's code aren't mentioned. Are they sticking to the old rules for now?

beorn7 commented 4 months ago

Very good point. We haven't thought about PGW yet. That needs more code changes, and some more ideas. sigh

beorn7 commented 4 months ago

For now, I would assume the PGW doesn't support the new UTF-8 names yet.

ywwg commented 4 months ago

We are making a note to create a design for this situation

Sinjo commented 4 months ago

That needs more code changes, and some more ideas. sigh

Happy to be of service 🙈