search

prometheus / common

Go libraries shared across Prometheus components and libraries.
Apache License 2.0
259 stars 306 forks source link

Version bump in prometheus/common breaks client_golang build #578

Closed shane-ns1 closed 4 months ago

shane-ns1 commented 4 months ago

It looks like the recent version bump of prometheus/common breaks the prometheus/client_golang build. I'm not sure whether this should be fixed in the prometheus/common or the prometheus/client_golang build (I guess probably in the prometheus/client_golang, but it was the prometheus/common version bump which broke things, so I'm filing the issue here):

/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText

Also, maybe the CI should be changed to spot these issues, since both repositories fall under the same organization in GitHub?

nicolaasuni-vonage commented 4 months ago

It looks like this is a duplicate of: https://github.com/prometheus/common/issues/577 that has been prematurely closed?

shane-ns1 commented 4 months ago

Possibly the golang_client code has been fixed, but there is no new release of the code so anyone installing the latest release of both libraries will have this problem.

SuperQ commented 4 months ago

Yes, we close issues once the code has been merged. We will need a new upstream release and bump of Go modules. But the issue can be closed to mark the fix as completed.

Duplicate of #557