prometheus / common

Go libraries shared across Prometheus components and libraries.
Apache License 2.0
259 stars 306 forks source link

Can client.key be removed as its giving security blocker in security scan? #614

Closed InduprasadSR closed 3 months ago

InduprasadSR commented 3 months ago

Hi https://github.com/prometheus/common/blob/main/config/testdata/client.key https://github.com/prometheus/common/blob/main/config/testdata/self-signed-client.crt https://github.com/prometheus/common/blob/main/config/testdata/self-signed-client.key https://github.com/prometheus/common/blob/main/config/testdata/server.key

As above keys are giving the security blocker from image scan, when I use this repo as a indirect dependency in go package, can I request to remove these keys from the repo "github.com/prometheus/common@v0.37.0/config/testdata/client.key" ...etc

image

SuperQ commented 3 months ago

No, these are necessary for unit tests.