search

prometheus / common

Go libraries shared across Prometheus components and libraries.
Apache License 2.0
259 stars 306 forks source link

Move goautoneg to external dependency #625

Closed mikelolasagasti closed 3 weeks ago

mikelolasagasti commented 2 months ago

goautoneg module was imported to the repo as it was hosted in bitbucket and required Mercurial at the time (2015).

Bitbucket repository is long gone and a GitHub fork is available under munnerz/goautoneg. This fork is used by other projects like Kubernetes.

yurishkuro commented 2 days ago

goautoneg uses an unusual license by Open Knowledge Foundation Ltd, which is not on the CNCF list https://github.com/cncf/foundation/blob/main/allowed-third-party-license-policy.md. Why is it acceptable as a dependency?

bboreham commented 1 day ago

https://github.com/munnerz/goautoneg/blob/master/LICENSE seems to me identical to https://opensource.org/license/BSD-3-Clause, with the addition of the line "All rights reserved." Is that what you are referring to as unusual ?

yurishkuro commented 1 day ago

GitHub would normally recognize BSD3 license. This one is just a bit different, but yeah, it looks BSD3.