Set http_headers to be omit empty

prometheus / common

Go libraries shared across Prometheus components and libraries.

Apache License 2.0

259 stars 306 forks source link

Set http_headers to be omit empty #655

Closed yeya24 closed 1 week ago

yeya24 commented 2 weeks ago

https://github.com/prometheus/common/pull/416 was introduced in release v0.54.0 to allow http_headers in the http client config.

This PR marks this new field omit empty so that an older version of Prometheus can run successfully using a config file marshalled with the newer version of the common library.

yeya24 commented 2 weeks ago

Can we merge this PR since we already have an approval? Thanks

yeya24 commented 1 week ago

cc @gotjosh @ArthurSens