search

prometheus / compliance

A set of tests to check compliance with various Prometheus interfaces
Apache License 2.0
127 stars 44 forks source link

Update version of OTel Collector #67

Closed gouthamve closed 2 years ago

gouthamve commented 2 years ago

See: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/7380

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

bmpandrade commented 2 years ago

@gouthamve / @tomwilkie , seems there is a lot of interest in updating this 🎉

This is the 3rd PR that has been approved but still lacking a merge. I opened one a few days back which update the version, download url and the metric.addr config to reflect the new changes. Please see here: https://github.com/prometheus/compliance/pull/65

Looking at your code and since it's updating for the *-contrib release, I wonder if there should be 2 targets, 1 for the main release and another for the contrib (this seems to overlap, but would be good to understand with which one we want to maintain this repo updated to.)

wdyt?

gouthamve commented 2 years ago

Hi, I think #65 is the better PR. I'll merge that one to unblock, and lets open an issue to see if we want contrib or otelcol.