search

prometheus / compliance

A set of tests to check compliance with various Prometheus interfaces
Apache License 2.0
128 stars 45 forks source link

Store and use archived filename in the bin directory #98

Open rapphil opened 1 year ago

rapphil commented 1 year ago

In the case of the remote_write_sender tests, use the archived filename to generate the filename of the binaries stored in bin and used for the tests.

The reason why we need this is because it will provide more stable filenames since the name will not rely on the name of the published artifact.

Before this change the files stored in bin after a run of go test --tags=compliance -run "TestRemoteWrite/.+" -v were:

agent-linux-amd64
otelcol_0.42.0_linux_amd64
prometheus-2.30.3.linux-amd64
telegraf-1.20.2_linux_amd64
vector-0.16.1-x86_64-unknown-linux-gnu
vmutils-amd64-v1.67.0

After:

agent-linux-amd64 
otelcol 
prometheus 
telegraf 
vector 
vmagent-prod

This will solve https://github.com/prometheus/compliance/issues/97

rapphil commented 1 year ago

@tomwilkie can you take a look into this pr?