search

prometheus / exporter-toolkit

Utility package to build exporters
Apache License 2.0
265 stars 81 forks source link

Change format of listen on vsock #219

Closed Leonid99 closed 6 months ago

Leonid99 commented 6 months ago

Before this change, the expected format of listening on vsock was "--web.listen-address=vsock://:9100". However, this URI-inspired format is probably confusing, especially given that it doesn't really support the host portion of the URI and that listening on TCP doesn't support the "http://:9100" syntax. This commit changes the expected format for vsock to be --web.listen-address=vsock:9100.

Leonid99 commented 6 months ago

Found #202 after publishing this PR. Should I just close this one? (They are identical, except for the expected format of the command line flag).

SuperQ commented 6 months ago

I think the other PR is mostly ready to go. Would you be interested in adding to the tests as mentioned in the comments after I merge it?

SuperQ commented 6 months ago

If you have any comments on the other PR, feel free to contribute there.

Leonid99 commented 6 months ago

If you have any comments on the other PR, feel free to contribute there.

Left a few comments.

Leonid99 commented 6 months ago

@SuperQ I rebased this branch on top of the one by @jeffrey4l to address my own remarks in his #202. Would you be interested in me rebasing this branch to resolve conflicts, so that we can merge it? I will obviously keep @jeffrey4l 's commits untouched to keep proper credit.