search

prometheus / exporter-toolkit

Utility package to build exporters
Apache License 2.0
265 stars 81 forks source link

omitempty for all struct fields #222

Open regnaio opened 5 months ago

regnaio commented 5 months ago

All fields , (e.g. in Config, TLSConfig) should have yaml:"<NAME>,omitempty"

https://github.com/prometheus/exporter-toolkit/blob/master/web/tls_config.go#L39

For example, it doesn't make sense that TLSConfig.MinVersion appears as 0 when marshaled to YAML. Prometheus crashes if you try to use this web config via --web.config.file=:

caller=main.go:949 level=error msg="Unable to validate web configuration file" err="unknown TLS version: 0"