strings.TrimRight is used instead of TrimSuffix - Githubissues

prometheus / procfs

procfs provides functions to retrieve system, kernel and process metrics from the pseudo-filesystem proc.

Apache License 2.0

769 stars 319 forks source link

strings.TrimRight is used instead of TrimSuffix #507

Closed GrosQuildu closed 4 months ago

GrosQuildu commented 1 year ago

This line aims to remove " kB" suffix, but instead removes all characters from " kB" cutset. https://github.com/prometheus/procfs/blob/cdc45126aef95c2e741f1d56ded3d24fdcd3d167/proc_smaps.go#L130

Similar fix as was done in this commit is required - https://github.com/prometheus/procfs/commit/b3d77ecba8e7aeb7b4ff946644b1013199656c42 .

discordianfish commented 1 year ago

Oops, thanks! Wanna submit a quick PR to fix this?