search

prometheus / procfs

procfs provides functions to retrieve system, kernel and process metrics from the pseudo-filesystem proc.
Apache License 2.0
754 stars 311 forks source link

Custom build tag "nostatfs" disables statfs #553

Closed mhutchinson closed 11 months ago

mhutchinson commented 11 months ago

This allows users to specify the "nostatfs" build tag to disable this feature if needed.

In our case, we are using Tamago (https://github.com/usbarmory/tamago), which does not support syscall.Statfs. Without this change attempting to build returns 'undefined: syscall.Statfs' and 'undefined: syscall.Statfs_t'. With this change, we can build successfully build our tamago executables provided that "nostatfs" is added to the build tags.

This option seems preferable to adding "tamago" as a build tag here, and will scale to other use cases too.

mhutchinson commented 11 months ago

Thanks for the quick review @SuperQ! So I can manage expectations, when is this likely to be merged and a release available?

SuperQ commented 11 months ago

Release v0.11.1 tagged.