search

prometheus / procfs

procfs provides functions to retrieve system, kernel and process metrics from the pseudo-filesystem proc.
Apache License 2.0
755 stars 311 forks source link

chore: class_fibrechannel: support optional attributes #607

Closed machine424 closed 4 months ago

SuperQ commented 4 months ago

It might be nice to change the struct values to be references, so we can differentiate between nil and 0. We do this in several other parsers.

machine424 commented 3 months ago

It might be nice to change the struct values to be references, so we can differentiate between nil and 0. We do this in several other parsers.

You're right, it may be confusing, especially that we allow missing counters files. It's worth an issue I think.

Could we expected a procfs release any soon? I can help if needed.

SuperQ commented 3 months ago

I can cut a release if we need one. Do you want to change the struct first? Or do that later?

machine424 commented 3 months ago

Yes, I need it for https://github.com/prometheus/node_exporter/pull/2933. Thanks. For the struct change, I'll create an issue and address it when I have some time.