search

prometheus / prometheus

The Prometheus monitoring system and time series database.
https://prometheus.io/
Apache License 2.0
55.69k stars 9.15k forks source link

Hetzner Robot SD: Use the Prometheus User Agent in HTTP requests #8003

Closed roidelapluie closed 4 years ago

roidelapluie commented 4 years ago

Proposal

Use case. Why is this important?

In the service discoveries, we add a User-Agent to identify the prometheus server and its version to the HTTP requests.

We should do the same for the newly added Hetzner SD. Note: only the Hetzner Robot calls role should have the user agent, as the hcloud already has a custom user agent set.

Here is an exemple of user agent we use: https://github.com/prometheus/prometheus/blob/50ae4e298bbb7f8628b0ac01cdd5f7d328b46051/discovery/dockerswarm/dockerswarm.go#L38

meetme2meat commented 4 years ago

Will take this up once https://github.com/prometheus/prometheus/pull/8006 get accepted.