search

prometheus / test-infra

Prometheus E2E benchmarking tool
Apache License 2.0
157 stars 69 forks source link

Rename load-generator to querier #313

Open geekodour opened 4 years ago

geekodour commented 4 years ago

https://github.com/prometheus/prombench/tree/master/tools/load-generator is the python querier, the name is confusing sometimes. should we change it to querier?

Also, the scaler config file is in the fake-webserver manifest file. Can we move it to the 6_loadgen.yaml https://github.com/prometheus/prombench/blob/ef0e09c928de60d4c14db39306003ef408f9a580/prombench/manifests/prombench/benchmark/2_fake-webserver.yaml#L1-L40

Also, is there any special reason to use the name "codelab" for the namespace in the fakewebserver metrics?

https://github.com/prometheus/prombench/blob/ef0e09c928de60d4c14db39306003ef408f9a580/tools/fake-webserver/server.go#L29

cc @krasi-georgiev

krasi-georgiev commented 4 years ago

IIRC the idea is to replace it complitely with a golang cli using the golang client library.

Also, is there any special reason to use the name "codelab" for the namespace in the fakewebserver metrics?

I don't know. I think it is safe to rename it.

bwplotka commented 1 month ago

I would do it (: