search

prometheus / test-infra

Prometheus E2E benchmarking tool
Apache License 2.0
156 stars 67 forks source link

Grafana: Fix `pr-number` variable #660

Closed aknuds1 closed 7 months ago

aknuds1 commented 7 months ago

Rename pr-number Grafana dashboard variable to prNumber, since dashes are not allowed in Grafana variable names. As a result, the variable wasn't working. Also, switch to newer variable expansion syntax (${prNumber} instead of [[prNumber]], as the latter is deprecated).

The variable's JSON changed a bit apart from the name, since I regenerated it within Grafana.

NB: I've tested locally, not in GitHub Actions. Not sure why I only discovered this problem locally. When deploying prombench locally, the Grafana version is 9.4.3.

github-actions[bot] commented 7 months ago

Grafana dashboard updated successfully.