search

prometheus / test-infra

Prometheus E2E benchmarking tool
Apache License 2.0
156 stars 67 forks source link

Rewrite load-generator in Go #688

Open SuperQ opened 4 months ago

SuperQ commented 4 months ago

The /tools/load-generator is the only component of this repo that is in Python. It would be nice to replace this with a Go binary in order to eliminate the Python ecosystem dependency for one tool. There are also no CI tests for this Python code, so we don't know if it's broken when Python or other requirements change.

Vandit1604 commented 2 months ago

I would like to pick this up.

HarshitNagpal29 commented 2 months ago

@SuperQ PTAL https://github.com/prometheus/test-infra/pull/725

Vandit1604 commented 2 months ago

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine. Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

HarshitNagpal29 commented 2 months ago

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine. Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

I am really sorry for not asking first, I thought you might not be working on it as it was assigned earlier but again completely my fault I should have communicated with you, will take care of this in future.

SuperQ commented 2 months ago

@Vandit1604 If you don't open a PR, nobody knows you're working on it. :smile:

Vandit1604 commented 2 months ago

Apologies, I didn't know that.

SuperQ commented 2 months ago

Feel free to submit your own solution. The current one does not pass tests.

Vandit1604 commented 2 months ago

I checked and found out that http://prombench.prometheus.io/14515/prometheus-pr is not found and is causing the querier to fail, with more than 30 404 status code is returned. I'll investigate the manifest files to see if there's some issue in nginx-ingress configurations.

SuperQ commented 1 month ago

Fixed in #748