search

prometheus / test-infra

Prometheus E2E benchmarking tool
Apache License 2.0
156 stars 67 forks source link

Support Validating Webhook Configuration resource in K8s package #719

Closed Vandit1604 closed 2 months ago

Vandit1604 commented 2 months ago

fixes: #718

We aren't supporting ValidatingWebhookConfiguration but using it in our cluster-infra manifest files for prombench.

Vandit1604 commented 2 months ago

I guess circleci failed because of my committed go.mod and go.sum. Removed them from the PR to check if that's the case.

yomek33 commented 2 months ago

I've encountered an error while applying a ValidatingWebhookConfiguration:

13:07:44 k8s.go:545: resource created - kind: Job, name: ingress-nginx-admission-patch
13:07:54 provider.go:74: Request for 'running job:ingress-nginx-admission-patch' is done!
13:07:54 k8s.go:703: resource updated - kind: IngressClass, name: nginx
Error parsing commandline arguments: error applying 'manifests/cluster-infra/2_ingress-nginx-controller.yaml' err:resource update failed - kind: ValidatingWebhookConfiguration, name: ingress-nginx-admission: validatingwebhookconfigurations.admissionregistration.k8s.io "ingress-nginx-admission" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update
usage: infra kind resource apply

It seems related to missing resourceVersion during an update.

Vandit1604 commented 2 months ago

Thanks @yomek33 for pointing this out.

Vandit1604 commented 2 months ago

Updated with changes. Thanks @yomek33