search

prometheus / test-infra

Prometheus E2E benchmarking tool
Apache License 2.0
156 stars 67 forks source link

annotation "kubernetes.io/ingress.class" is deprecated, use 'spec.ingressClassName' instead #720

Closed yomek33 closed 1 week ago

yomek33 commented 2 months ago

The annotation kubernetes.io/ingress.class is deprecated and generates a warning in Kubernetes logs. The current configuration should be updated to use the spec.ingressClassName field instead. https://github.com/prometheus/test-infra/blob/34a189da3778d9035d430e3213f5c9dd18d520a7/prombench/manifests/cluster-infra/3b_prometheus-meta.yaml#L260 https://github.com/prometheus/test-infra/blob/34a189da3778d9035d430e3213f5c9dd18d520a7/prombench/manifests/cluster-infra/7b_commentmonitor_deployment.yaml#L73 It may appear in other parts of yaml files.

FYI: More details about this deprecation and changes can be found in https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#deprecating-the-ingress-class-annotation

bwplotka commented 2 weeks ago

Fixed in https://github.com/prometheus/test-infra/pull/726

bboreham commented 1 week ago

Apparently making this change broke everything. Maybe some other change was needed?

bboreham commented 1 week ago

Should it be a field in the spec object, and not an annotation?

bwplotka commented 1 week ago

Ups, sorry, didn't actually apply to check... my fault

bboreham commented 1 week ago

Should be fixed by #770