prometheusresearch-archive / react-forms

Forms library for React.
1.16k stars 112 forks source link

Recently added "release" isn't recent #101

Closed warrenfalk closed 9 years ago

warrenfalk commented 9 years ago
npm install react-forms

Is currently resulting in downloading of v0.5.7 which results in the following error when using anything else that's recent

npm ERR! peerinvalid Peer react-router@0.13.3 wants react@0.13.x
npm ERR! peerinvalid Peer react-forms@0.5.7 wants react@^0.10.0
haywoood commented 9 years ago

Yea, does anyone know how to build a stand alone global version of this from master?

bsr203 commented 9 years ago

@andreypopp has been pushing updates to the master branch and you may better off using directly from github. may be try npm install prometheusresearch/react-forms. "version": "1.0.0-rc3",

Also, the next version of this app is in at next branch and has significant API changes. https://github.com/prometheusresearch/react-forms/tree/next "version": "2.0.0", he just pushed these changes and I have success just cloning this repo and (check out next if you want the latest) and build yourself.

you can see few issues in the issue list as there wasn't any update to this package for some time, and getting excited to see the new updates.

Cheers

haywoood commented 9 years ago

Yea, I'm just having a rough go at figuring out which browserify command will give me a result like this file from the react-forms-build repo, from master.

haywoood commented 9 years ago

So far I have browserify lib/index.js -s ReactForms --no-bundle-external -o react-forms.js and I've added browserify-shim to my package.json so I can convert require('react/addons') and require('immutable') to window.React and window.Immutable respectively. Close but no cigar atm.

bsr203 commented 9 years ago

well, the next version has a proper build setup. for the current one you are referring to, I just include it in my project. but, the code in lib is not transpiled, so I use webpack to include this folder.

sorry, no idea about browserify

{
    test: /\.js$/,
    loaders: prod ? ['babel-loader?stage=0'] : ['react-hot', 'babel-loader?stage=0'],
    include: [path.join(__dirname, 'src'), path.join(__dirname, 'node_modules/react-forms/lib')]
    // exclude: /node_modules/
},
{
    test: /\.jsx$/,
    loaders: prod ? ['babel-loader?stage=0'] : ['react-hot', 'babel-loader?stage=0'],
    // exclude: /node_modules/
    include: [path.join(__dirname, 'src'),
      include: [path.join(__dirname, 'src'), path.join(__dirname, 'node_modules/react-forms/lib')]
},
haywoood commented 9 years ago

Awesome, thanks for the info! I think I have it actually, the build repo's package.json has some good leads and I think it's working in my app. Just sorting out errors regarding abstract nodes, I unfortunately started using this library with the very outdated version :P

chiefjester commented 9 years ago

@bsr203 stage 0? Yikes, so its subject to change without any notice by babel

Subject to change These proposals are subject to change so use with extreme caution. Babel may update without warning in order to track spec changes.

It means your code might break out of the blue without you even knowing. It's essentially for non-production build this next thing?

bsr203 commented 9 years ago

well I wasn't using all the features of stage 0, but some selected ones like object spread. It is also possible to specify what you use instead of stage 0 as a webpack config. I was just showing that it is easy to use this package with webpack than anything (it uses some es7 features).

for next version, you need nothing as it has a built version.

chiefjester commented 9 years ago

oh okay so next version, stage 2 is fine (enabled by default)? by the way object spread is stage 1. The lower the number the more dangerous it is because those spec might change without prior notice.

andreypopp commented 9 years ago

Expect release candidate for 2.0 soon.