Fix for PR #298 to drop out of order webhook events

promhippie / github_exporter

Prometheus exporter for GitHub

https://promhippie.github.io/github_exporter/

Apache License 2.0

94 stars 14 forks source link

Fix for PR #298 to drop out of order webhook events #299

Closed raz-amir closed 5 months ago

raz-amir commented 5 months ago

Fix PR https://github.com/promhippie/github_exporter/pull/298 that fixed https://github.com/promhippie/github_exporter/issues/296

The code didn't query the db for the updated_at field, so the comparison was always to 0 timestamp. Also added some info to the debug prints

raz-amir commented 5 months ago

@tboerger, this fixes the issue. Sorry about that. I wasn't sure if you would want a separate changelog, so I added one just in case. Added some debug information to the logs, that I think is useful, but feel free to drop it.

tboerger commented 5 months ago

The new release haven't been tagged, please drop the extra changelog and just add the pull request url to the existing one.

tboerger commented 5 months ago

I have applied some minor changes and will merge it when it's green.