search

promhippie / github_exporter

Prometheus exporter for GitHub
https://promhippie.github.io/github_exporter/
Apache License 2.0
105 stars 17 forks source link

Failed to parse github event (field custom_properties) #398

Open ardole opened 3 days ago

ardole commented 3 days ago

When using webhook to export workflows event, i got the following error in the exporter:

{"error":"json: cannot unmarshal array into Go struct field Repository.repository.custom_properties of type string","level":"error","msg":"failed to parse github event"...

It looks like the json format send by Github is not the one you expect, especially on field custom_properties. I may come from https://github.com/google/go-github/issues/3229 which was fixed, then i think that you have updated the dependency as well.

I'm using the HelmChart and it runs the version 

Image:          quay.io/promhippie/github-exporter:3.1.2                                                                                                                               │
Image ID:       quay.io/promhippie/github-exporter@sha256:25eb9b1a7ac7bd82d3fe59ae3ee59abf6da61d8fc2b0d32d3a0945269b4a4a4d

What can happen, is the image not fully up to date ?

tboerger commented 2 days ago

Thanks for reporting this. Can you verify that the latest tag fixes the issue?

Than it's really just doing a new release to include the fix of the go library.

ardole commented 2 days ago

That's it, latest is working :) Thank you

tboerger commented 2 days ago

Thanks for the confirmation, I will check if there are other changes that got to be added and hopefully provide a new release next week.