prominence-eosc / prominence

PROMINENCE server
Apache License 2.0
2 stars 0 forks source link

Replace system periodic remove with system periodic hold #124

Open alahiff opened 4 years ago

alahiff commented 4 years ago

Currently using SYSTEM_PERIODIC_REMOVE and SYSTEM_PERIODIC_REMOVE_REASON to remove jobs when needed due to problems. However, SYSTEM_PERIODIC_REMOVE_REASON is actually undocumented and doesn't always work (found it many years ago in a BB GitHub repo). It does appear to sometimes work however!

Consider changing to SYSTEM_PERIODIC_HOLD and SYSTEM_PERIODIC_HOLD_REASON, and change SYSTEM_PERIODIC_REMOVE as appropriate. Jobs can change to periodic_hold and periodic_hold_reason. Will need to change the python code to use HoldReason in addition to RemoveReason.