prominence-eosc / prominence

PROMINENCE server
Apache License 2.0
2 stars 0 forks source link

Retries for artifact / container image downloads? #3

Open alahiff opened 5 years ago

alahiff commented 5 years ago

Should we retry if an artifact fails to download? Should we retry if a container image fails to download?

alahiff commented 4 years ago

Now that download of artifacts has been moved to the promlet, this can be more easily done if needed.

alahiff commented 4 years ago

Should definitely implement this. Just noticed a failed download from Docker Hub causing a job to fail:

Unable to pull docker://alahiff/cherab-jet:dev: conveyor failed to get: Error initializing source oci:/home/user/.singularity/cache/oci:f6bfb083ea37681f1a30f41e39175d47595ec9602cfb7ee64243e9900f26d7a0: Error reading blob sha256:ff95660c69375e19e287b2ea87ca9b4be008cd036e95d541515262b86cc521d9: Get https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/ff/ff95660c69375e19e287b2ea87ca9b4be008cd036e95d541515262b86cc521d9/data?verify=1580315706-cY8f8kKbvlbOemjMNtJKBYoJmnk%3D: net/http: TLS handshake timeout

Numbers of retries should be reported in the json generated by promlet.