Encode sink parameter "interval" is incorrectly named and documented. Rename to "iframe_interval"

prominenceai / deepstream-services-library

A shared library of on-demand DeepStream Pipeline Services for Python and C/C++

MIT License

288 stars 67 forks source link

Closed rjhowell44 closed 2 months ago

rjhowell44 commented 2 months ago

This is for all Encode Sinks; File, Record, RTMP, RTSP Client, RTSP Server, and WebRTC Sinks.

The parameter is currently named and documented as

interval - [in] frame interval at which to encode the video. Set to 0 to code every frame.

Which is completely wrong. It needs to be

iframe_interval -[in] intra frame (key-frame) occurrence interval.

This parameter should be set to 1x or 2x the frame-rate and not 0