search

prominenceai / deepstream-services-library

A shared library of on-demand DeepStream Pipeline Services for Python and C/C++
MIT License
288 stars 67 forks source link

Encode sink parameter "codec" is incorrectly named and documented. Rename to "encoder" #1274

Closed rjhowell44 closed 2 months ago

rjhowell44 commented 2 months ago

All Encode Sinks are to be updated to support software Encoding (#1273 ), and with this change the symbolic constants below:

#define DSL_CODEC_H264                                              0
#define DSL_CODEC_H265                                              1

will be replaced with the following Encoder constants

#define DSL_ENCODER_HW_H264                                         0
#define DSL_ENCODER_HW_H265                                         1
#define DSL_ENCODER_SW_H264                                         2
#define DSL_ENCODER_SW_H265                                         3
#define DSL_ENCODER_SW_MPEG4                                        4

The parameter name to set the encoder type is currently called codec which is not accurate and should be updated to encoder