search

promisefeni / reallysimplehistory

Automatically exported from code.google.com/p/reallysimplehistory
Other
0 stars 0 forks source link

firstLoad not initialized properly #38

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Using rsh-RC1.

On lines 140 & 146 this.firstLoad is initialized properly for IE6 but in
the corresponding code for other browsers on lines 114-126 the
initialization for  "this.firstLoad = false;" is missing why a comparison
"dhtmlHistory.isFirstLoad() === false" behaves irratically. 

Also there is the minor issue of using "isFirstLoad() === null" for
checking if rsh is initialized.

Original issue reported on code.google.com by patrik.k...@gmail.com on 7 Dec 2007 at 5:14

GoogleCodeExporter commented 8 years ago 
I can see exactly where this is missing for non-IE browsers. I think this is
something I inherited from 0.4 but I will have to check. Regardless, this 
should be
easy to fix so that isFirstLoad() always returns true or false.

Original comment by bdpathfi...@gmail.com on 11 Dec 2007 at 6:06

GoogleCodeExporter commented 8 years ago 
I've fixed this in the 0.8 branch and added a log statement for it in the 
onload event.

Original comment by bdpathfi...@gmail.com on 11 Dec 2007 at 11:27