promises-aplus / cancellation-spec

Discussion and drafts of a possible promise cancellation spec.
24 stars 5 forks source link

Canceled vs. Cancelled #4

Open novemberborn opened 11 years ago

novemberborn commented 11 years ago

We'll have to pick one and stick to it. There's some nice background at http://grammarist.com/spelling/cancel/.

@domenic any leanings to one or the other in ES-discuss?

domenic commented 11 years ago

Not that I can see. I've seen "cancelled" the state and "AlreadyCanceled" as an error.

Precedent from other implementations might be the strongest argument. WinJS seems to use cancelled.

novemberborn commented 11 years ago

Dojo uses canceled, which I picked as it was the shortest one.

juandopazo commented 11 years ago

As a non native speaker, I think I've never written canceled, only cancelled.

ForbesLindesay commented 11 years ago

I think we can safely settle on cancellation/cancelled. It's the correct, native English spelling and I think even the Americans might spell it with two 'l's.

novemberborn commented 11 years ago

I think even the Americans might spell it with two 'l's.

It's a mix. NYT shows an order of magnitude difference, preferring "canceled": https://www.google.com/search?q=%22canceled%22%20site:nytimes.com vs https://www.google.com/search?q=%22cancelled%22%20site:nytimes.com.

juandopazo commented 11 years ago

Google Trends show an inclination for "cancelled": http://www.google.com/trends/explore#q=cancelled%2C%20canceled&cmpt=q

novemberborn commented 11 years ago

Sure, but that's global. I'm presuming words in computer languages default to American English.

That said, color wins over colour, and behavior over behaviour, so if cancelled wins over canceled perhaps that's enough.

ludekstepan commented 11 years ago

Please see a Microsoft implementation of Promise.cancel: http://msdn.microsoft.com/en-us/library/windows/apps/br211667.aspx

spankyj commented 10 years ago

In WinJS we use 'Canceled' https://github.com/winjs/winjs/blob/master/src/js/base/promise.js#L12. We had a long debate on an internal alias years ago and settled on that.

ludekstepan commented 10 years ago

In cases like this, I would stick to forms with less characters.