search

promises-aplus / promises-spec

An open standard for sound, interoperable JavaScript promises—by implementers, for implementers.
https://promisesaplus.com/
Creative Commons Zero v1.0 Universal
1.84k stars 171 forks source link

add Potential to implementations #200

Closed glebec closed 8 years ago

glebec commented 9 years ago

Wrote this small package as an educational exercise, and will probably extend it with basic library functions like all, spread, etc. in the future. It passes the current compliance tests, so perchance it could be added to the Promises/A+ implementations list?

briancavalier commented 8 years ago

Hey @glebec, sorry to take a bit to get back to you on this. All the tests pass, nice job. However, when I run them via npm test, it hangs after all the tests have run. IOW, the process never exits. That could mean you have a stray timeout or some other resource tied up, and node believes that it shouldn't exit. I let it sit for 60 seconds or so, and it never exited. Could you take a look into that? Thanks!

glebec commented 8 years ago

Ah — didn't even realize there was a process.exit in the test file. I'll look into it. I was considering a substantial 2.0.0 refactor anyway so if and when I get it working I'll report back. Thanks!

glebec commented 8 years ago

@briancavalier Never let it be said that I don't (eventually) call back… This weekend I got around to figuring out what was up. It was very nasty to debug, an infinite mutual recursion that was caused by a totally non-essential convenience feature I had put in as an afterthought.

Anyway, now it passes the specs and terminates. Thanks for considering including this library; cheers, —G.

briancavalier commented 8 years ago

Hey @glebec, thanks for following up! I just tried v1.3.0 and everything looks good. Merging.